New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs Amend JS Foundation to OpenJS Foundation (#3971) #4044
Closed
Closed
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
09846fc
docs Amend JS Foundation to OpenJS Foundation
leehwarang 1b63c2f
docs Amend JS Foundation to OpenJS Foundation
leehwarang 91e9c55
docs Amend JS Foundation to OpenJS Foundation
leehwarang b7754f3
docs Amend JS Foundation to OpenJS Foundation
leehwarang File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is correct. This is legal, therefore quite sensitive stuff.
Is it still MIT license?
2011-2019: OpenJS Foundation exists since 2018?
This concerns legal issues and you have to be careful what you are changing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@juergba I didn't know a legal issue.
How we descibe the copyright? "Since 2011" part needed?
Copyright (c) 2011-2019 OpenJS Foundation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know. You could study OpenJSFoundation's homepage, or study repos of other packages, or ask jorydotcom or ask boneskull.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jorydotcom
Do you know about this legal issue?
Copyright (c) 2011-2019 OpenJS Foundation
orCopyright (c) 2019 OpenJS Foundation
.We don't know a legal issue.