Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add node 12 to build; remove node 11 #3940

Closed
wants to merge 1 commit into from

Conversation

boneskull
Copy link
Member

node 11 is no longer maintained

@boneskull boneskull added type: chore generally involving deps, tooling, configuration, etc. semver-patch implementation requires increase of "patch" version number; "bug fixes" labels Jun 5, 2019
@coveralls
Copy link

coveralls commented Jun 5, 2019

Coverage Status

Coverage remained the same at 92.353% when pulling 81a0433 on boneskull/node-12-build into f3ed729 on master.

@boneskull
Copy link
Member Author

to be clear about the why's of that hack around browser tests:

  1. the browser tests are the only place where we allow native modules to be downloaded and/or compiled. we need these to launch the browser tests.
  2. unfortunately, this also means we get canvas, which is a transient dependency of builder.
  3. canvas provides a prebuilt binary for node 10
  4. canvas does not provide a prebuilt binary for node 12, which means we must compile it from source
  5. ...and the prerequisites to do so are not available in the default travis environment

So we could either download all of those dependencies (which is a handful of stuff grabbed via apt) and build canvas from source which we won't even use, because it's for building the docs.... or we just run the browser tests in Node.js v10. the Node.js version doesn't really matter, because these are browser tests, after all.

@boneskull
Copy link
Member Author

I would not consider this a breaking change as long as we support versions of Node.js prior to v11. We can consider this "implicit support".

in the far future, when we drop Node.js v10 support, we will be essentially dropping Node.js v11 support as well.

@boneskull
Copy link
Member Author

closing in lieu of #3919

@boneskull boneskull closed this Jun 6, 2019
@boneskull boneskull deleted the boneskull/node-12-build branch June 6, 2019 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-patch implementation requires increase of "patch" version number; "bug fixes" type: chore generally involving deps, tooling, configuration, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants