Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI config files to use Node-12.x #3919

Merged
merged 4 commits into from Jun 12, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 4 additions & 1 deletion .travis.yml
Expand Up @@ -11,10 +11,11 @@ stages:

# defaults
language: node_js
node_js: '11'
node_js: '12'
addons:
apt:
packages:
# Growl
- libnotify-bin
# `nvm install` happens before the cache is restored, which means
# we must install our own npm elsewhere (`~/npm`)
Expand Down Expand Up @@ -49,6 +50,8 @@ jobs:
node_js: '6'

- script: npm start test.bundle test.browser
# XXX: update when canvas supplies a prebuilt binary for Node.js v12.x
node_js: 10
install: npm ci # we need the native modules here
addons:
artifacts:
Expand Down
11 changes: 9 additions & 2 deletions appveyor.yml
Expand Up @@ -12,7 +12,7 @@ shallow_clone: true
clone_depth: 1
environment:
matrix:
- nodejs_version: '11'
- nodejs_version: '12'
- nodejs_version: '10'
- nodejs_version: '8'
- nodejs_version: '6'
Expand All @@ -35,7 +35,14 @@ install:
## Node-related installs
- ps: Add-AppveyorMessage "Installing Node..."
- set PATH=%APPDATA%\npm;C:\MinGW\bin;%PATH%
- ps: Install-Product node $env:nodejs_version x64
## Prefer pre-installed Node versions, with fallback to manual update
- ps: |
try {
Install-Product node $env:nodejs_version $env:platform
} catch {
Add-AppveyorMessage " install failed - attempting manual update..."
Update-NodeJsInstallation (Get-NodeJsLatestBuild $env:nodejs_version) $env:platform
}
- ps: Add-AppveyorMessage "Installing npm..."
- npm install -g npm
## Mocha-related package installs
Expand Down