Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Node v12 in test matrix instead v11 #3891

Closed
wants to merge 4 commits into from

Conversation

outsideris
Copy link
Member

Today Node v12 has been released. So, it's a new current version of Node.
Test mocha with Node v12 instead of v11.

@outsideris outsideris added area: node.js command-line-or-Node.js-specific semver-patch implementation requires increase of "patch" version number; "bug fixes" labels Apr 24, 2019
@outsideris
Copy link
Member Author

AppVeyor has a problem with Node v12. I will dig it.

@outsideris outsideris self-assigned this Apr 24, 2019
@juergba
Copy link
Member

juergba commented Apr 24, 2019

boneskull/node-environment-flags should also be revised.
The Node flags for the release v12 have to be added.

@juergba
Copy link
Member

juergba commented Apr 30, 2019

@outsideris I just realised it's not necessary to update "boneskull/node-environment-flags".:

If the current Node.js version is v10.10.0 or newer, the native implementation will be provided instead.

=> native implementation: process.allowedNodeEnvironmentFlags

@juergba
Copy link
Member

juergba commented Apr 30, 2019

Travis also fails with:

1) node-flags
       isNodeFlag()
         special cases
           should return true for flags starting with "preserve-symlinks":
     UnexpectedError: 
expected true to be false

see PR #3900

@coveralls
Copy link

coveralls commented May 9, 2019

Coverage Status

Coverage increased (+0.07%) to 91.888% when pulling dc833e5 on outsideris:node-v12 into 9b00fed on mochajs:master.

Signed-off-by: Outsider <outsideris@gmail.com>
@plroebuck
Copy link
Contributor

Rebase and try this again.

@outsideris
Copy link
Member Author

I already rebased this. However, there is a weired error at npm ci.
Also, AppVeyor looks that still doesn't to support node v12. So, I'm trying to test it with Travis Windows Supporting.

Until pre-installed Node-12 image available, switched from `Install-Product` to slower `Update-NodeJSInstallation`.
Added `libpango` to attempt to get `canvas` to build on Node-12 for browser tests.
Try again, this time adding _all_ external libraries from its [Ubuntu installation instructions](https://github.com/Automattic/node-canvas/wiki/Installation:-Ubuntu-and-other-Debian-based-systems).
@boneskull
Copy link
Member

I think we should go with #3919, ty.

@boneskull boneskull closed this Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: node.js command-line-or-Node.js-specific semver-patch implementation requires increase of "patch" version number; "bug fixes"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants