Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Matamo logo to website #3749

Closed
wants to merge 2 commits into from
Closed

Add Matamo logo to website #3749

wants to merge 2 commits into from

Conversation

vrozin
Copy link

@vrozin vrozin commented Feb 20, 2019

Description of the Change

  1. Added Matamo logo to README.md file at the bottom of the page as an honorable sponsor.
  2. Created "backers" folder under project's assets to store the badge image

Alternate Designs

Was asked to attach the logo at the bottom,, in a separate list. The logo is centered, though it can be relocated.

Why should this be in core?

N/A

Benefits

Mocha mentions its sponsor.

Possible Drawbacks

NA

Applicable issues

Fixes #3705
semver-patch

@jsf-clabot
Copy link

jsf-clabot commented Feb 20, 2019

CLA assistant check
All committers have signed the CLA.

@plroebuck plroebuck added area: documentation anything involving docs or mochajs.org semver-patch implementation requires increase of "patch" version number; "bug fixes" area: website involving mochajs.org, but not necessarily involving docs labels Feb 20, 2019
@plroebuck plroebuck changed the title Fixes #3705 Add Matamo logo to website Feb 20, 2019
@vrozin
Copy link
Author

vrozin commented Feb 20, 2019

Seems like the tests have been past.
May I have any further instructions?

Copy link
Member

@boneskull boneskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This issue was to update the site, not the README. 😉

Instructions for how to build the site can be found here.

Copy link
Member

@boneskull boneskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(requesting changes)

@coveralls
Copy link

coveralls commented Feb 28, 2019

Coverage Status

Coverage increased (+0.03%) to 91.713% when pulling c5571b1 on vrozin:issue-3705 into 22831c5 on mochajs:master.

@vrozin
Copy link
Author

vrozin commented Mar 1, 2019

@boneskull Ohh thanks for pointing this out! I was under impression that README.md was supposed to be modified... Sorry about that.
I applied changes to the docs/index.md, now it has the "Honourable Mentions" section, right below the list of sponsors.
I added "honorableMentions.md" (US spelling) to docs/_includes/. It loads Matomo logo from assets folder.

I was also wondering if I can compile it all-together in eleventy. I installed markdown-magic, but I still can't see the badge being loaded when I run the built index.html on localhost:8080. However, I can see the badge in my repo's honorableMentions.md
Edit: it does display the logo when the link is a URL though, not a path to a file.

@juergba
Copy link
Member

juergba commented Feb 8, 2020

already fixed by #3765.
@vrozin I'm sorry, thank you anyway for your PR.

@juergba juergba closed this Feb 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: documentation anything involving docs or mochajs.org area: website involving mochajs.org, but not necessarily involving docs semver-patch implementation requires increase of "patch" version number; "bug fixes"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add Matomo badge to site
6 participants