Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix .globals to remove falsy values #3737

Merged
merged 7 commits into from Feb 17, 2019
Merged

Fix .globals to remove falsy values #3737

merged 7 commits into from Feb 17, 2019

Commits on Feb 16, 2019

  1. fix(lib/mocha.js): Remove falsy values from .globals 

    Added filter to remove "undefined"/empty string values.
    @plroebuck
    plroebuck committed Feb 16, 2019
    Copy the full SHA
    15b5bd7 View commit details
    Browse the repository at this point in the history

  2. test(unit/mocha.spec.js): Add test for .globals

    @plroebuck
    plroebuck committed Feb 16, 2019
    Copy the full SHA
    89a723d View commit details
    Browse the repository at this point in the history

  3. refactor(unit/mocha.spec.js): Reorder option tests lexically 

    **No changes to actual code.** Just put `describe`s in order.
    @plroebuck
    plroebuck committed Feb 16, 2019
    Copy the full SHA
    fe90346 View commit details
    Browse the repository at this point in the history

  4. test(unit/mocha.spec.js): Annotate prototype tests 

    Changed `describe` titles from `.method` to `#method` for Mocha prototypes.
    @plroebuck
    plroebuck committed Feb 16, 2019
    Copy the full SHA
    d11e5f5 View commit details
    Browse the repository at this point in the history

  5. refactor(unit/mocha.spec.js): Rename suite title 'error handling' as … 

    …'#reporter()'

Renamed suite and migrated lexically. Added its chainable test.
    @plroebuck
    plroebuck committed Feb 16, 2019
    Copy the full SHA
    442205f View commit details
    Browse the repository at this point in the history

  6. refactor(unit/mocha.spec.js): Reparented '#reporter("xunit")#run(fn)'… 

    … test suite

Moved aforementioned suite inside '#run()' test suite. Don't see its value as a variant of the
original test, but...
    @plroebuck
    plroebuck committed Feb 16, 2019
    Copy the full SHA
    bf9939b View commit details
    Browse the repository at this point in the history

  7. test(unit/mocha.spec.js): Change verbage of test titles for #globals

    @plroebuck
    plroebuck committed Feb 16, 2019
    Copy the full SHA
    c638cbe View commit details
    Browse the repository at this point in the history