Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use constants for event names instead of string literals #3655

Merged
merged 1 commit into from Feb 4, 2019

Commits on Feb 4, 2019

  1. refactor: use constants for event names instead of string literals

    - also a few other string literals got replaced, but not error messages nor codes
    - supporting refactors:
      - move the suite "GC" function into the `Suite` prototype
      - move stats collector init to `Mocha#run` due to circular reference with `Runner`
      - rename a couple fixture files lacking proper extension
      - rename variable in integration test helpers
      - add `utils.createMap()` and `utils.defineConstants()`
      - add `test/integration/fixtures` to `.eslintignore` so no fixture linting occurs whatsoever
      - consolidated use of `object.assign` polyfill into `utils` module
      - some docstring fixes/consistency
      - adds `EVENT_DELAY_END` emitted from `Runner` for reporter use
    - specifically did NOT refactor event names from Node.js incl. `error` and `uncaughtException`
    - add custom reporter tutorial to API documentation
        - automatically injects reporter example into tutorial via `markdown-magic`
        - add `docs.preprocess.api` script
        - add JSDoc configuration to support tutorials
        - sort JSDoc config object because fussy
    - fix broken custom assertion
    boneskull committed Feb 4, 2019
    Copy the full SHA
    51ec4af View commit details
    Browse the repository at this point in the history