Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix test running on windows #3653

Merged
merged 1 commit into from Jan 17, 2019
Merged

fix test running on windows #3653

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
164 changes: 70 additions & 94 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions package-scripts.js
View file
Open in desktop
Expand Up @@ -217,26 +217,26 @@ module.exports = {
description: 'Run browser tests'
},
unit: {
script: 'NODE_PATH=. karma start --single-run',
script: 'cross-env NODE_PATH=. karma start --single-run',
description: 'Run browser unit tests'
},
bdd: {
script: 'MOCHA_TEST=bdd nps test.browser.unit',
script: 'cross-env MOCHA_TEST=bdd nps test.browser.unit',
description: 'Run browser BDD interface tests',
hiddenFromHelp: true
},
tdd: {
script: 'MOCHA_TEST=tdd nps test.browser.unit',
script: 'cross-env MOCHA_TEST=tdd nps test.browser.unit',
description: 'Run browser TDD interface tests',
hiddenFromHelp: true
},
qunit: {
script: 'MOCHA_TEST=qunit nps test.browser.unit',
script: 'cross-env MOCHA_TEST=qunit nps test.browser.unit',
description: 'Run browser QUnit interface tests',
hiddenFromHelp: true
},
esm: {
script: 'MOCHA_TEST=esm nps test.browser.unit',
script: 'cross-env MOCHA_TEST=esm nps test.browser.unit',
description: 'Run browser ES modules support test',
hiddenFromHelp: true
}
Expand Down
4 changes: 3 additions & 1 deletion package.json
View file
Open in desktop
Expand Up @@ -517,6 +517,7 @@
"chai": "^4.2.0",
"coffee-script": "^1.10.0",
"coveralls": "^3.0.2",
"cross-env": "^5.2.0",
boneskull marked this conversation as resolved.
Show resolved Hide resolved
"cross-spawn": "^6.0.5",
"eslint": "^5.10.0",
"eslint-config-prettier": "^3.3.0",
Expand Down Expand Up @@ -582,7 +583,8 @@
},
"prettier": {
"singleQuote": true,
"bracketSpacing": false
"bracketSpacing": false,
"endOfLine": "auto"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lexical order?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unless we can lint and automatically format it, I'm not interested in enforcing lexical order anywhere. it's nice, but also IMO a nit.

Copy link
Contributor

@plroebuck plroebuck Jan 17, 2019 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unless we can lint and automatically format it, I'm not interested in enforcing lexical order anywhere. it's nice, but also IMO a nit.

Wholeheartedly disagree. We shouldn't require lint and autoformat just to put items in lexical order, and not doing so just makes maintenance harder (requiring search rather than skim). There are only two properties in this file ('prettier' and 'yargs') that really aren't, and both can be trivially corrected.

},
"yargs": {
"combine-arrays": true,
Expand Down