Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump glob patch version to remove warning #2201

Merged
merged 1 commit into from
Apr 15, 2016
Merged

Conversation

astorije
Copy link
Contributor

When installing mocha@2.4.5, glob@3.2.3 triggers the following warning:

npm WARN deprecated graceful-fs@2.0.3: graceful-fs version 3 and before will fail on newer node releases. Please update to graceful-fs@^4.0.0 as soon as possible.

This commit bumps to the latest patch version before a major version.
Diff at isaacs/node-glob@v3.2.3...v3.2.11.

When installing `mocha@2.4.5`, `glob@3.2.3` triggers the following warning:

```
npm WARN deprecated graceful-fs@2.0.3: graceful-fs version 3 and before will fail on newer node releases. Please update to graceful-fs@^4.0.0 as soon as possible.
```

This commit bumps to the latest patch version before a major version.
Diff at isaacs/node-glob@v3.2.3...v3.2.11.
@graingert
Copy link
Contributor

#2121 (comment)

@astorije
Copy link
Contributor Author

@graingert, does this apply with this patch bump too (from v3.2.3 to v3.2.11). I was under the impression that the code changes were rather safe, but people say in the comments that if breaks old versions of npm. I thought the breakage was introduced later, in a major version bump.

@Turbo87
Copy link
Contributor

Turbo87 commented Apr 14, 2016

@astorije if you want to stay on the safe side use v3.2.6 instead.

isaacs/node-glob@v3.2.3...v3.2.6 only seems to include the removal of graceful-fs

@danielstjules would that be something you're okay with?

@boneskull
Copy link
Member

OK, looks like 3.2.10 is not safe, but 3.2.11 is safe:

$ npm install glob@3.2.10
npm http GET https://registry.npmjs.org/glob/3.2.10
npm http 200 https://registry.npmjs.org/glob/3.2.10
npm http GET https://registry.npmjs.org/glob/-/glob-3.2.10.tgz
npm http 200 https://registry.npmjs.org/glob/-/glob-3.2.10.tgz
npm http GET https://registry.npmjs.org/inherits
npm http GET https://registry.npmjs.org/minimatch
npm http 304 https://registry.npmjs.org/inherits
npm http 304 https://registry.npmjs.org/minimatch
npm ERR! Error: No compatible version found: minimatch@'^0.3.0'
npm ERR! Valid install targets:
npm ERR! ["0.0.1","0.0.2","0.0.4","0.0.5","0.1.1","0.1.2","0.1.3","0.1.4","0.1.5","0.2.0","0.2.2","0.2.3","0.2.4","0.2.5","0.2.6","0.2.7","0.2.8","0.2.9","0.2.10","0.2.11","0.2.12","0.2.13","0.2.14","0.3.0","0.4.0","1.0.0","2.0.0","2.0.1","2.0.2","2.0.3","2.0.4","2.0.5","2.0.6","2.0.7","2.0.8","2.0.9","2.0.10","3.0.0"]
npm ERR!     at installTargetsError (/Users/boneskull/.nvm/v0.8.28/lib/node_modules/npm/lib/cache.js:719:10)
npm ERR!     at /Users/boneskull/.nvm/v0.8.28/lib/node_modules/npm/lib/cache.js:641:10
npm ERR!     at saved (/Users/boneskull/.nvm/v0.8.28/lib/node_modules/npm/node_modules/npm-registry-client/lib/get.js:138:7)
npm ERR!     at Object.oncomplete (fs.js:302:15)
npm ERR! If you need help, you may report this log at:
npm ERR!     <http://github.com/isaacs/npm/issues>
npm ERR! or email it to:
npm ERR!     <npm-@googlegroups.com>

npm ERR! System Darwin 15.4.0
npm ERR! command "/Users/boneskull/.nvm/v0.8.28/bin/node" "/Users/boneskull/.nvm/v0.8.28/bin/npm" "install" "glob@3.2.10"
npm ERR! cwd /private/tmp
npm ERR! node -v v0.8.28
npm ERR! npm -v 1.2.30
npm ERR!
npm ERR! Additional logging details can be found in:
npm ERR!     /private/tmp/npm-debug.log
npm ERR! not ok code 0
$ npm install glob@3.2.11
npm http GET https://registry.npmjs.org/glob/3.2.11
npm http 200 https://registry.npmjs.org/glob/3.2.11
npm http GET https://registry.npmjs.org/glob/-/glob-3.2.11.tgz
npm http 200 https://registry.npmjs.org/glob/-/glob-3.2.11.tgz
npm http GET https://registry.npmjs.org/inherits
npm http GET https://registry.npmjs.org/minimatch
npm http 200 https://registry.npmjs.org/inherits
npm http 200 https://registry.npmjs.org/minimatch
npm http GET https://registry.npmjs.org/lru-cache
npm http GET https://registry.npmjs.org/sigmund
npm http 200 https://registry.npmjs.org/sigmund
npm http 200 https://registry.npmjs.org/lru-cache
glob@3.2.11 node_modules/glob
├── inherits@2.0.1
└── minimatch@0.3.0 (sigmund@1.0.1, lru-cache@2.7.3)

Thanks!

@boneskull boneskull merged commit 7920fc4 into mochajs:master Apr 15, 2016
@astorije astorije deleted the patch-1 branch April 18, 2016 02:59
@Turbo87
Copy link
Contributor

Turbo87 commented Apr 28, 2016

@boneskull @danielstjules any chance of a patch release in the near future including this fix?

@darkmorpher
Copy link

Related:
#2234 & #2262

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants