Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

devDeps: remove 'cross-spawn' #4779

Merged
merged 1 commit into from Oct 29, 2021
Merged

devDeps: remove 'cross-spawn' #4779

merged 1 commit into from Oct 29, 2021

Conversation

juergba
Copy link
Member

@juergba juergba commented Oct 26, 2021 •
edited

Description

We use cross-spawn in our integration tests only.
We remove it from our devDependencies and use Node's native child-process module instead, which has been stable for many years now.

@juergba juergba added type: chore generally involving deps, tooling, configuration, etc. semver-patch implementation requires increase of "patch" version number; "bug fixes" area: node.js command-line-or-Node.js-specific dependencies Pull requests that update a dependency file labels Oct 26, 2021
@juergba juergba self-assigned this Oct 26, 2021
@juergba juergba requested a review from a team October 26, 2021 16:54
nicojs
nicojs approved these changes Oct 26, 2021
View reviewed changes
Copy link
Contributor

@nicojs nicojs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@juergba juergba merged commit 3b4cc05 into master Oct 29, 2021
@juergba juergba deleted the juergba/cross-spawn branch October 29, 2021 07:16
@juergba juergba added this to the next milestone Oct 29, 2021
KuznetsovRoman pushed a commit to gemini-testing/mocha that referenced this pull request Sep 6, 2022
@juergba @KuznetsovRoman
chore(devDeps): remove 'cross-spawn' (mochajs#4779)
9dee633
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicojs nicojs nicojs approved these changes

Assignees

@juergba juergba

Labels
area: node.js command-line-or-Node.js-specific dependencies Pull requests that update a dependency file semver-patch implementation requires increase of "patch" version number; "bug fixes" type: chore generally involving deps, tooling, configuration, etc.
Projects
None yet
Milestone
v9.1.4
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@juergba @nicojs