Skip to content

Commit

Permalink
\#3128 replace phantomjs with puppeteer for browser tests
Browse files Browse the repository at this point in the history
  • Loading branch information
akrawchyk committed Dec 13, 2017
1 parent 6fc2d9e commit c5a128b
Show file tree
Hide file tree
Showing 5 changed files with 126 additions and 1,316 deletions.
2 changes: 1 addition & 1 deletion README.md
Expand Up @@ -11,7 +11,7 @@
1. Increase test coverage on Node.js and browser
- Increase integration coverage for all reporters
- `html` reporter must be tested in browser
- ~~Basic console reporters (*not* `nyan`, `landing`, etc.) must be tested in **both** browser and Node.js contexts; PhantomJS can consume all console reporters~~
- ~~Basic console reporters (*not* `nyan`, `landing`, etc.) must be tested in **both** browser and Node.js contexts~~
- ~~Filesystem-based reporters must be tested in Node.js context~~
- **UPDATE - May 24 2017**: Thanks to [community contributions](https://github.com/mochajs/mocha/blob/master/CHANGELOG.md#mag-coverage), the coverage on most reporters has increased dramatically! The `html` reporter is still in [dire need of coverage](https://coveralls.io/builds/11674428/source?filename=lib%2Freporters%2Fhtml.js).
- Increase coverage against all interfaces (`exports` in particular). Ideally this becomes a "matrix" where we repeat sets of integration tests across all interfaces.
Expand Down
1 change: 0 additions & 1 deletion appveyor.yml
Expand Up @@ -8,7 +8,6 @@ install:
- ps: Install-Product node $env:nodejs_version
- set CI=true
- set PATH=%APPDATA%\npm;c:\MinGW\bin;%PATH%
- set PHANTOMJS_CDNURL=https://cnpmjs.org/downloads
- npm install -g npm
- npm install
- copy c:\MinGW\bin\mingw32-make.exe c:\MinGW\bin\make.exe
Expand Down
3 changes: 2 additions & 1 deletion karma.conf.js
Expand Up @@ -51,7 +51,7 @@ module.exports = function (config) {
},
reporters: ['mocha'],
colors: true,
browsers: ['PhantomJS'],
browsers: ['ChromeHeadless'],
logLevel: config.LOG_INFO,
client: {
mocha: {
Expand Down Expand Up @@ -116,6 +116,7 @@ module.exports = function (config) {
}
mkdirp.sync(bundleDirpath);
} else {
env.CHROME_BIN = require('puppeteer').executablePath();
console.error('CI mode disabled');
}

Expand Down

0 comments on commit c5a128b

Please sign in to comment.