windows: keyToString(): fix string conversion (for real) #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
force-pushed
the
fix_windows_conversion_again
branch
from
fd55730
to
2ba61c1
Compare
I must've been sleeping while writing 2ce69ef, because while it "fixed" the error, the intent here obviously is to return the actual character, not the number ':-) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
fix_windows_conversion_again
branch
from
2ba61c1
to
abe3d01
Compare
|
@dims ptal 🙈 😊 🤗 |
dims
approved these changes
May 1, 2023
|
Thx! Yeah, looks like there we no tests at all in that Windows package. We should add more (I need to get access to a Windows machine; might be a bit easier to write and verify them) I'll bring this one in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I must've been sleeping while writing 2ce69ef (#39), because while it "fixed" the error, the intent here obviously is to return the actual character, not the number ':-)