Deprecate IsConsole in favor of "golang.org/x/.." implementations #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
commented
May 7, 2020
thaJeztah
force-pushed
the
deprecate_isconsole
branch
from
dfd17f9
to
83adc13
Compare
thaJeztah
changed the title
thaJeztah
commented
May 7, 2020
This removes the github.com/Azure/go-ansiterm/winterm dependency from the windowsconsole package, and replaces it with `golang.org/x/sys/windows`. Marking this function as deprecated, given that this functionality is already provided by the "standard" `golang.org/x/..` packages. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
deprecate_isconsole
branch
from
83adc13
to
57a2131
Compare
|
Looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the github.com/Azure/go-ansiterm/winterm dependency from the windowsconsole package, and replaces it with
golang.org/x/sys/windows.Marking this function as deprecated, given that this functionality is already provided by the "standard"
golang.org/x/..packages.