Drop go < 1.16 compatibility #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Go 1.15 is not supported since Go 1.17 release in August 2021. This is mostly so we can use replacements for ioutil functions (note that we do not have to replace all ioutil uses for now, as it is still not deprecated), as well as testing.TestDir and such. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
This is mostly to have the same x/sys/unix version in all modules. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
This was referenced Oct 28, 2021
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go 1.15 is not supported since Go 1.17 release in August 2021.
This is mostly so we can use new functionality, such as
(*testing.T).TestDir,as well as replacements for ioutil functions.
NOTE we do not have to replace all ioutil uses yet, as it is still not deprecated.
This is just to open a way to use whatever is available in Go 1.16.
Also, some go-1.16 and go-1.17 related cleanups.