mountinfo: GetMountsFromReader() remove workaround for kernel < 3.10 #83
+6
−82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kolyshkin
reviewed
Aug 14, 2021
| @@ -504,66 +499,6 @@ func TestParseFedoraMountinfoFilterFields(t *testing.T) { | |||
| } | |||
| } | |||
|
|
|||
| func TestParseMountinfoWithSpaces(t *testing.T) { | |||
There was a problem hiding this comment.
I don't understand how removing this test is relevant to this commit.
In Linux <= 3.9 mounting a cifs with spaces in a share name (like "//srv/My Docs") _may_ end up having a space in the last field of mountinfo (like "unc=//serv/My Docs"). Since kernel 3.10-rc1, cifs option "unc=" is ignored, so spaces should not appear. Given that all major distros are now on at least kernel 3.10, and (e.g.) docker has not supported older kernel versions for 5 Years [1], it should be save to remove this special handling. [1]: moby/moby@51b23d8 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
mountinfo_remove_kernel_3.9_support
branch
from
8832f96
to
955e12d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow-up to #81
In Linux <= 3.9 mounting a cifs with spaces in a share name (like "//srv/My Docs")
may end up having a space in the last field of mountinfo (like "unc=//serv/My Docs").
Since kernel 3.10-rc1, cifs option "unc=" is ignored, so spaces should not appear.
Given that all major distros are now on at least kernel 3.10, and (e.g.) docker
has not supported older kernel versions for 5 Years 1, it should be save to
remove this special handling.