signal: fix name for SIGBUS on darwin #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed that the name for `SIGBUS` on Darwin was mapped to `BUG`. To be sure that a `BUG` signal is not actually a "thing", I looked at the history for this; this mapping was originally added in: moby/moby@10dc16d, Looking at the Darwin headers, I also don't see a mention of a `BUG` signal: https://github.com/apple/darwin-xnu/blob/b6dbbb99918752ac84da97aa9b473bd974afc609/bsd/sys/signal.h#L98, So, I'm assuming this was a rather funny slip-up, which makes this a "BUS-FIX" ? Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
|
@tianon @cpuguy83 @kolyshkin PTAL 😂 |
|
(sorry @creack, @thaJeztah finally caught your |
|
One more incoming, but this one was too funny not to keep it separate |
|
nice one :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the name for
SIGBUSon Darwin was mapped toBUG. To be sure that aBUGsignal is not actually a "thing", I looked at the history for this; this mapping was originally added in: moby/moby@10dc16d (moby/moby#4563),Looking at the Darwin headers, I also don't see a mention of a
BUGsignal:https://github.com/apple/darwin-xnu/blob/b6dbbb99918752ac84da97aa9b473bd974afc609/bsd/sys/signal.h#L98,
So, I'm assuming this was a rather funny slip-up, which makes this a "BUS-FIX" ?