signal: Handle more signals to make ParseSignal containerd compatible #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelkarp
reviewed
Jul 23, 2021
signal/signal_windows.go
Outdated
| "HUP": syscall.Signal(windows.SIGHUP), | ||
| "INT": syscall.Signal(windows.SIGINT), | ||
| "QUIT": syscall.Signal(windows.SIGQUIT), | ||
| "SIGILL": syscall.Signal(windows.SIGILL), |
There was a problem hiding this comment.
You probably need "ILL", not "SIGILL".
Suggested change
| "SIGILL": syscall.Signal(windows.SIGILL), | |
| "ILL": syscall.Signal(windows.SIGILL), |
There was a problem hiding this comment.
Yep. Fixed in the last revision.
kzys
commented
Jul 23, 2021
signal/signal_windows.go
Outdated
| "HUP": syscall.Signal(windows.SIGHUP), | ||
| "INT": syscall.Signal(windows.SIGINT), | ||
| "QUIT": syscall.Signal(windows.SIGQUIT), | ||
| "SIGILL": syscall.Signal(windows.SIGILL), |
There was a problem hiding this comment.
It is SIGSIGILL since 2017. Looks like a typo though...
There was a problem hiding this comment.
Yeah I think it's likely a typo in the original.
There was a problem hiding this comment.
Especially since CI is passing now 😆
We'd like to use moby/sys/signal in containerd, but containerd currently supports more signals. Adding them here closes the gap. Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
thaJeztah
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We'd like to use moby/sys/signal in containerd, but containerd currently
supports more signals. Adding them here closes the gap.
Signed-off-by: Kazuyoshi Kato katokazu@amazon.com