Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mount, mountinfo: Add support for OpenBSD in addition to FreeBSD #32

Merged
merged 1 commit into from
Oct 1, 2020

Conversation

thaJeztah
Copy link
Member

I am looking at using these modules in containerd, so that we can
reduce the effort of maintaining "mountinfo" implementations.

The containerd variant of this module currently supports OpenBSD in
addition to FreeBSD.

This patch bring in changes similar to the ones made in containerd in:

containerd/containerd@0828b7a

@tklauser
Copy link
Contributor

Just noticed that #36 might conflict with this. x/sys/unix provides the MNT_* flags for OpenBSD as well, so it should be easy to adjust either of the PRs, depending on which one gets merged first.

@thaJeztah
Copy link
Member Author

Thanks for the heads-up!

@kolyshkin
Copy link
Collaborator

Means we need to close #24

@thaJeztah thaJeztah marked this pull request as ready for review September 28, 2020 09:11
@kolyshkin
Copy link
Collaborator

Wonder if containerd has actual *BSD users, or is the situation similar to moby/moby Solaris support?

@kolyshkin
Copy link
Collaborator

Needs a rebase

I am looking at using these modules in containerd, so that we can
reduce the effort of maintaining "mountinfo" implementations.

The containerd variant of this module currently supports OpenBSD in
addition to FreeBSD.

This patch bring in changes similar to the ones made in containerd in:

containerd/containerd@0828b7a

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Copy link
Member Author

@kolyshkin rebased (and green 👍)

Copy link
Collaborator

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kolyshkin kolyshkin merged commit 9fe7f4e into moby:master Oct 1, 2020
@thaJeztah thaJeztah deleted the mountinfo_bsd branch October 1, 2020 23:28
@thaJeztah thaJeztah changed the title Add support for OpenBSD in addition to FreeBSD mount, mountinfo: Add support for OpenBSD in addition to FreeBSD Nov 10, 2020
@thaJeztah thaJeztah mentioned this pull request Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants