Bump CI to use supported go version, fix a single Go 1.20 issue in mount pkg; rm uneeded errorlint annotations #129
+29
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kolyshkin
changed the title
thaJeztah
reviewed
Aug 25, 2023
kolyshkin
force-pushed
the
bump-ci
branch
2 times, most recently
from
5a708b5
to
ba81eaa
Compare
|
@thaJeztah ptal |
thaJeztah
reviewed
Aug 31, 2023
mount/go.mod
Outdated
| @@ -4,5 +4,5 @@ go 1.17 | |||
|
|
|||
| require ( | |||
| github.com/moby/sys/mountinfo v0.6.2 | |||
| golang.org/x/sys v0.0.0-20220520151302-bc2c85ada10a | |||
| golang.org/x/sys v0.11.0 | |||
There was a problem hiding this comment.
if we don't need anything newer, I prefer follow Go module's "minimum version selection", and use the oldest tagged version (v0.1.0), and leave it up to users of this module to pick the version they want
There was a problem hiding this comment.
Done, PTAL @thaJeztah
|
@kolyshkin are you ok with picking a "minimum" version for golang.org/x/sys, or did you have a specific reason to require the latest version? |
Yes, I don't think we have a requirement for a specific version here. Will update. |
Since Go 1.20,
> [t]he fmt.Errorf function now supports multiple occurrences of the %w
> format verb, which will cause it to return an error that wraps all of
> those error operands.
This change, together with newer errorlint, causes the following
warning:
> mount_unix.go:74:56: non-wrapping format verb for fmt.Errorf. Use `%w` to format errors (errorlint)
> return fmt.Errorf("%w (possible cause: %s)", err, suberr)
> ^
As we still want to support Go 1.17, use explicit string for suberr,
and add a TODO to switch to %w once we switch to Go 1.20+.
Fixes: 487129d
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
1. Test with supported Go releases (1.20.x and 1.21.x). Also leave Go 1.17.x since it costs us little to keep supporting it. 2. Bump golangci-lint to the latest released version (v1.55.1). 3. Bump actions/setup-go to v4. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
It is already that way for sequential, and Go 1.17 is the oldest version we use in CI, so let's bring other modules go.mod in sync. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
This is the oldest tagged version of x/sys. This allows to follow Go module's "minimum version selection", leaving it up to users of this module to pick the version they want. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
golangci-lint v1.54.2 comes with errorlint v1.4.4, which contains the fix [1] whitelisting all errno comparisons for errors coming from x/sys/unix. Remove the annotation that is no longer needed. Unfortunately, switch on a bare unix error (in mountinfo) still needs to be annotated (see [2]). [1] polyfloyd/go-errorlint#47 [2] polyfloyd/go-errorlint#54 Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
This fixes the following CI error: > sequential_windows.go:114: File is not `gofumpt`-ed (gofumpt) Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
|
@thaJeztah ptal |
1 similar comment
|
@thaJeztah ptal |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v0.11.0.v.0.1.0.