sequential: refactor, and update godoc #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't mix-and-mash packages for consts. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Move the error-handling to openFileSequential and update exported functions to use openFileSequential instead of OpenFile(). Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
The non-Windows implementations are aliases for the "os" stdlib package equivalents. This patch removes the local documentation, as it was out of date for some, and having the local documentation could give the impression that these functions were anything other than an alias. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Update the docs to refer to the "os" stdlib equivalents, and describe the changes compared to those, instead of replicating the os package's documentation. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
sequential_cleanup
branch
from
a4fd063
to
432b7c8
Compare
|
@kolyshkin @cpuguy83 PTAL |
|
@kolyshkin @cpuguy83 @AkihiroSuda PTAL 🤗 |
AkihiroSuda
approved these changes
Jul 16, 2023
|
Thx! Let me bring this one in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sequential: consistently use x/sys/windows for consts
Don't mix-and-mash packages for consts.
sequential: open(File)Sequential: remove unused arg
sequential: move error-handling to openFileSequential
Move the error-handling to openFileSequential and update exported functions to use openFileSequential instead of OpenFile().
sequential: simplify docs for non-Windows implementations
The non-Windows implementations are aliases for the "os" stdlib package equivalents. This patch removes the local documentation, as it was out of date for some, and having the local documentation could give the impression that these functions were anything other than an alias.
sequential: update docs for Windows-implementation
Update the docs to refer to the "os" stdlib equivalents, and describe the changes compared to those, instead of replicating the os package's documentation.