Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add go mod tidy check #119

Merged
merged 1 commit into from Jun 6, 2022
Merged

ci: add go mod tidy check #119

merged 1 commit into from Jun 6, 2022

Conversation

kolyshkin
Copy link
Collaborator

This step should fail if a PR author bumped or added some dependencies,
or bumped go version in go.mod, but forgot to run go mod tidy.

Inspired by #118 (comment)

@kolyshkin
Copy link
Collaborator Author

Adding an extra commit to check that CI works as intended (supposed to fail with it)

This step should fail if a PR author bumped or added some dependencies,
or bumped go version in go.mod, but forgot to run go mod tidy.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
@kolyshkin
Copy link
Collaborator Author

OK, go mod tidy step fails as expected with the test commit added (see e.g. https://github.com/moby/sys/runs/6761754513?check_suite_focus=true), removing the test commit.

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah merged commit 71f84a8 into moby:main Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants