[18.09 backport] Fix update out of sequence and increase max recv gRPC message size for nodes and secrets

[thaJeztah]

built on top of #2836 ([18.09 backport] Switch to go 1.11) rebased

relates to

• integration-cli: fix swarm tests flakiness moby#39531 integration-cli: fix swarm tests flakiness
• [18.09 backport] integration-cli: fix swarm tests flakiness docker/engine#346 [18.09 backport] integration-cli: fix swarm tests flakiness

Backports of

• Increased wait time on test utils WaitForCluster and WatchTaskCreate #2762 Increased wait time on test utils WaitForCluster and WatchTaskCreate
• Allow using Configs as CredentialSpecs #2771 Allow using Configs as CredentialSpecs
  • second commit only (attempt to fix weirdly broken tests)
• Fix flaky tests #2808 Fix flaky tests
• Swap gometalinter for golangci-lint #2866 Swap gometalinter for golangci-lint
• Increase max recv gRPC message size to initialize connection broker #2869 Increase max recv gRPC message size to initialize connection broker
• related / similar to cluster: set bigger grpc limit for array requests moby#38103 / [18.06] cluster: set bigger grpc limit for array requests docker/engine#102 cluster: set bigger grpc limit for array requests
• related / similar to Increase max recv gRPC message size for nodes and secrets moby#39306 Increase max recv gRPC message size for nodes and secrets
• fixes Error generated when messages size is too big #2733 Error generated when messages size is too big
• Fix update out of sequence #2870 Fix update out of sequence

Cherry-pick were clean, no conflicts

# https://github.com/docker/swarmkit/pull/2762 Increased wait time on test utils WaitForCluster and WatchTaskCreate
git cherry-pick -s -S -x 5f167cab731ee75bc6cf3888fd2a4a5b5194f924

# second commit from https://github.com/docker/swarmkit/pull/2771 Allow using Configs as CredentialSpecs
git cherry-pick -s -S -x be26111c4a48c44fac04c17c69fd2504aea6db91

# https://github.com/docker/swarmkit/pull/2808 Fix flaky tests
git cherry-pick -s -S -x 06a356671bc11e4fd5d754f257f9c5f93ec5c563

# https://github.com/docker/swarmkit/pull/2866 Swap gometalinter for golangci-lint
git cherry-pick -s -S -x 27c2d27e23e76243bb49ec5d803a6e40b3f96f7a

# https://github.com/docker/swarmkit/pull/2869 Increase max recv gRPC message size to initialize connection broker
git cherry-pick -s -S -x 127e816ed8c8de4c981e02c9d0b45c70d3baa824

# https://github.com/docker/swarmkit/pull/2870 Fix update out of sequence
git cherry-pick -s -S -x d68ac46e3b11d7384472677d210bb0ce941284dc

[thaJeztah]

Argh; I suspect this is running Go 1.13, and related to golang/go#34073 / golang/go#31859

#!/bin/bash -eo pipefail
make check binaries checkprotos
🐳 check
ERRO Running error: context loading failed: failed to load program with go/packages: unsupported version of go: exit status 2: flag provided but not defined: -compiled
usage: list [-e] [-f format] [-json] [build flags] [packages]
Run 'go help list' for details.
 
make: *** [check] Error 3
Exited with code 2

[thaJeztah]

Oh... the reverse; it's still on Go 1.10 😞

[thaJeztah]

rebased on top of #2836; marked as WIP and will rebase once that's merged

[codecov]

Codecov Report

Merging #2900 into bump_v18.09 will decrease coverage by 0.03%.
The diff coverage is 31.25%.

@@               Coverage Diff               @@
##           bump_v18.09    #2900      +/-   ##
===============================================
- Coverage        61.79%   61.75%   -0.04%     
===============================================
  Files              134      134              
  Lines            21869    21875       +6     
===============================================
- Hits             13513    13508       -5     
- Misses            6894     6912      +18     
+ Partials          1462     1455       -7

[thaJeztah]

Failure is a flaky test; #2559

--- FAIL: TestUpdaterRollback (35.31s)
    --- FAIL: TestUpdaterRollback/pause/monitor_set/spec_version_unset (3.61s)
        update_test.go:272: service was updated
	Error Trace:	testutils.go:42
			update_test.go:343
			update_test.go:20
	Error:		no task creation
            

    --- FAIL: TestUpdaterRollback/continue/spec_version_set (30.00s)
        update_test.go:272: service was updated
        update_test.go:324: test timed out before watchServiceUpdate provided an event
FAIL
coverage: 84.9% of statements
FAIL	github.com/docker/swarmkit/manager/orchestrator/replicated	37.618s
make: *** [coverage] Error 1
Exited with code 2

I'll try restarting CI

[thaJeztah]

rebased 👍

[thaJeztah]

@dperny this one's green, and probably ready to go