Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use archive.CopyWithTar in vfs.Create #8802

Merged
merged 1 commit into from
Oct 27, 2014
Merged

Use archive.CopyWithTar in vfs.Create #8802

merged 1 commit into from
Oct 27, 2014

Commits on Oct 27, 2014

  1. Use archive.CopyWithTar in vfs.Create 

    The vfs storage driver currently shells out to the `cp` binary on the host
system to perform an 'archive' copy of the base image to a new directory.
The archive option preserves the modified time of the files which are created
but there was an issue where it was unable to preserve the modified time of
copied symbolic links on some host systems with an outdated version of `cp`.

This change no longer relies on the host system implementation and instead
utilizes the `CopyWithTar` function found in `pkg/archive` which is used
to copy from source to destination directory using a Tar archive, which
should correctly preserve file attributes.

Docker-DCO-1.1-Signed-off-by: Josh Hawn <josh.hawn@docker.com> (github: jlhawn)
    Josh Hawn committed Oct 27, 2014
    Configuration menu
    Copy the full SHA
    b6db23c View commit details
    Browse the repository at this point in the history