Cleanup: correct cli --volumes-from description #7640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
issue moby#7580 volumes-from comma separated list mentioned this case. Options like --volumes-from=[] indicate they can be specified multiple times: docker run -it --rm --volumes-from TEST_DATA --volumes-from TEST_DATA2 ubuntu bash Signed-off-by: Deshi Xiao <dxiao@redhat.com>
|
LGTM. Thanks. Be good if whitespace was separated into another commit in future. |
jamtur01
added a commit
that referenced
this pull request
Aug 20, 2014
Cleanup: correct cli --volumes-from description
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue #7580 volumes-from comma separated list mentioned this case.
Options with [] may be specified multiple times.
Example:
case 1, works:
docker run -it --rm --volumes-from TEST_DATA --volumes-from TEST_DATA2 ubuntu
bash
case 2, failed:
docker run -it --rm --volumes-from TEST_DATA,TEST_DATA2 ubuntu bash
2014/08/20 15:40:35 Error response from daemon: Cannot start container
e2f63ce5611c7a1be28389580d4a3847713078e6d5b61aac6cd532ec68b02191: Container
TEST_DATA,TEST_DATA2 not found. Impossible to mount its volumes
Signed-off-by: Deshi Xiao dxiao@redhat.com