Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - IPv6 Container Support #6923

Closed
wants to merge 5 commits into from
Closed

WIP - IPv6 Container Support #6923

wants to merge 5 commits into from

Conversation

ajwdev
Copy link
Contributor

@ajwdev ajwdev commented Jul 9, 2014

This is a work in progress pull request based on the work previously done in #2974. Please see the last few comments on that thread for context.

This branch needs merged/rebased onto the master as its currently based on the 0.8 release.

cvlc and others added 5 commits December 9, 2013 18:10
Conflicts:
	AUTHORS
	container.go
	lxc_template.go
	network.go
	network_test.go

Docker-DCO-1.1-Signed-off-by: Andrew Williams <williams.andrew@gmail.com> (github: TheDude05)
This is based on the work done in PR moby#2974

Docker-DCO-1.1-Signed-off-by: Andrew Williams <williams.andrew@gmail.com> (github: TheDude05)
Conflicts:
	container.go
	networkdriver/network_test.go
Docker-DCO-1.1-Signed-off-by: Andrew Williams <williams.andrew@gmail.com> (github: TheDude05)
@ajwdev ajwdev mentioned this pull request Jul 9, 2014
@LK4D4
Copy link
Contributor

LK4D4 commented Jul 11, 2014

Okay, @TheDude05. I think we should break this PR to smaller. For example I can try to adapt your ipallocator code.

@ajwdev
Copy link
Contributor Author

ajwdev commented Jul 23, 2014

I took another look at this over the last couple of days and found that some changes will have to happen in libcontainer as well as it only supports one IP address per interface. I agree that it would probably make sense to add IPv6 support to some of the supporting systems (such as the ipallocator) and then start lifting changes from the old branch in #2974 once that is there. At this point I think the code in this branch is too old to even bother trying to sort out the merge conflicts.

I'm going to start on the libcontainer side and come back to this

@crosbymichael
Copy link
Contributor

I'm closing this for now because it is a WIP PR. Feel free to ask for help in an issue or start submitting smaller PRs as you complete this work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants