raw json for docker save
#6571
Merged
raw json for docker save
#6571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docker-DCO-1.1-Signed-off-by: Victor Vieux <vieux@docker.com> (github: vieux)
Docker-DCO-1.1-Signed-off-by: Victor Vieux <vieux@docker.com> (github: vieux)
Docker-DCO-1.1-Signed-off-by: Victor Vieux <vieux@docker.com> (github: vieux)
| func (img *Image) JsonData() ([]byte, error) { | ||
| root, err := img.root() | ||
| if err != nil { | ||
| return nil, fmt.Errorf("Failed to get root for image %s: %s", image.ID, err) |
There was a problem hiding this comment.
@vbatts s/image/img/g
image/image.go:155: undefined: image
image/image.go:159: undefined: image
image/image.go:163: undefined: image
|
@tiborvass fixed |
Docker-DCO-1.1-Signed-off-by: Vincent Batts <vbatts@redhat.com> (github: vbatts)
|
LGTM |
|
How many PRs are you two going to make ;) just joking |
|
@crosbymichael SUCH PR |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR includes #6461
Fix #6455
Fix #6340
Close #6385
Close #6461