Deprecated and moved writeflusher impl to internal pkg #47718
+197
−84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krissetto
force-pushed
the
writeflusher-internal-impl
branch
2 times, most recently
from
0ad6eb4
to
e76e088
Compare
krissetto
force-pushed
the
writeflusher-internal-impl
branch
from
e76e088
to
b4ebe28
Compare
laurazard
added
status/2-code-review
kind/refactor
…Flusher Signed-off-by: Christopher Petito <47751006+krissetto@users.noreply.github.com>
…riteHeader() on first Flush()) Signed-off-by: Christopher Petito <47751006+krissetto@users.noreply.github.com>
krissetto
force-pushed
the
writeflusher-internal-impl
branch
from
b4ebe28
to
d020e95
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Flush()func to also callWriteHeader()on the underlying io.Writer if it's anhttp.ResponseWriter.This is needed to ensure that we don't try to send headers multiple times if the writer has already been wrapped by OTEL instrumentation (which doesn't wrap the
Flush()func. See Syslog entry: "superfluous response.WriteHeader call" in Docker 25.x #47448)How I did it
I moved the old impl to
internal/writeflusher, and created aNewLegacyWriteFlusher()func that the old exportedNewWriteFlusher()func calls to maintain the original behavior. All code using this deprecated version from theioutilspkg should be unaffectedHow to verify it
Usual tests should run as usual, as this shouldn't have any effect
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)
