[25.0 backport] ci/validate-pr: Use ::error:: command to print errors
#47703
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will make Github render the log line as an error. Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com> (cherry picked from commit fb92caf) Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
austinvazquez
approved these changes
Apr 30, 2024
crazy-max
reviewed
Apr 30, 2024
Comment on lines
13
to
15
| run: | | ||
| echo "Every PR with an \`impact/*\` label should also have an \`area/*\` label" | ||
| echo "::error::Every PR with an 'impact/*' label should also have an 'area/*' label" | ||
| exit 1 |
There was a problem hiding this comment.
As follow-up we could look at using https://github.com/actions/github-script:
uses: actions/github-script@v7
with:
script: |
core.setFailed(`Every PR with an 'impact/*' label should also have an 'area/*' label`);There was a problem hiding this comment.
core module API here: https://github.com/actions/toolkit/tree/main/packages/core#actionscore
There was a problem hiding this comment.
Is there any visual difference between these though?
corhere
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
::error::command to print errors #47682This will make Github render the log line as an error.
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)