New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Makefile: refactoring .PHONY #47656
Makefile: refactoring .PHONY #47656
Conversation
Thank you for contributing! It appears your commit message is missing a DCO sign-off, We require all commit messages to have a
There is no need to open a new pull request, but to fix this (and make CI pass), Unfortunately, it's not possible to do so through GitHub's web UI, so this needs You can find some instructions in the output of the DCO check (which can be found Steps to do so "roughly" come down to:
Sorry for the hassle (I wish GitHub would make this a bit easier to do), and let me know if you need help or more detailed instructions! |
Signed-off-by: xiaochangbai <704566072@qq.com>
this ok,thank you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh! missed that it was updated
LGTM, thanks!
PHONY is set on one line, which makes it cumbersome and difficult to maintain as more functions are added. And I found that many functions were not set to enter PHONY
Now set your own PHONY for each function
The changes are as follows:
1、modify: These are all set on the top line of the corresponding function
2、addition: test-integration-cli