Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[23.0] Vendor rootlesskit v2 #47258

Open
wants to merge 8 commits into
base: 23.0
Choose a base branch
from
Open

[23.0] Vendor rootlesskit v2 #47258

wants to merge 8 commits into from
+1,841 −961

Conversation

aepifanov
Copy link

Vendor rootlesskit v2 and all dependencies

@aepifanov
vendor: gotest.tools/v3 v3.5.1
27c9432 
full diff: https://github.com/gotestyourself/gotest.tools/compare/v3.5.0..v3.5.1

Signed-off-by: Andrey Epifanov <aepifanov@mirantis.com>
@aepifanov
vendor: golang.org/x/sys v0.16.0
d0c5589 
full diff: golang/crypto@v0.13.0...v0.18.0

Signed-off-by: Andrey Epifanov <aepifanov@mirantis.com>
@aepifanov
vendor: github.com/sirupsen/logrus v1.9.3
4b820e2 
full diff: https://github.com/sirupsen/logrus/compare/v1.9.0..v1.9.3

Signed-off-by: Andrey Epifanov <aepifanov@mirantis.com>
@aepifanov
vendor: github.com/google/go-cmp v0.6.0
8337c92 
full diff: https://github.com/google/go-cmp/compare/v0.5.9..v0.6.0

Signed-off-by: Andrey Epifanov <aepifanov@mirantis.com>
@aepifanov
vendor: github.com/google/uuid v1.5.0
3df2db4 
full diff: https://github.com/google/uuid/compare/v1.3.0..v1.5.0

Signed-off-by: Andrey Epifanov <aepifanov@mirantis.com>
@aepifanov
vendor: github.com/gorilla/mux v1.8.1
1a4c2f4 
full diff: https://github.com/gorilla/mux/compare/v1.8.0..v1.8.1

Signed-off-by: Andrey Epifanov <aepifanov@mirantis.com>
@aepifanov
vendor: github.com/moby/sys/mountinfo v0.7.1
89653fe 
full diff: https://github.com/moby/sys/compare/mountinfo/v0.6.1..mountinfo/v0.7.1

Signed-off-by: Andrey Epifanov <aepifanov@mirantis.com>
@aepifanov
vendor: github.com/rootless-containers/rootlesskit/v2 v2.0.0
a4b98a8 
full diff: https://github.com/rootless-containers/rootlesskit/compare/v1.1.0..v2.0.0

Signed-off-by: Andrey Epifanov <aepifanov@mirantis.com>
@AkihiroSuda AkihiroSuda added the area/rootless Rootless mode label Jan 31, 2024
@thaJeztah thaJeztah changed the title Vendor rootlesskit v2 [23.0] Vendor rootlesskit v2 Jan 31, 2024
thaJeztah
thaJeztah requested changes Jan 31, 2024
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was this intended for the 23.0 branch?

corhere
corhere approved these changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@corhere corhere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is intended for v23

@thaJeztah
Copy link
Member

🤦 looked from my phone and didn't consider who opened the PR. Do we need similar backports for 24 and 25? Otherwise newer versions use an older version of rootlesskit?

@aepifanov
Copy link
Author

🤦 looked from my phone and didn't consider who opened the PR. Do we need similar backports for 24 and 25? Otherwise newer versions use an older version of rootlesskit?

Sure, I'll take care about it

@thaJeztah
Copy link
Member

Also heads-up that there was a regression in v2.0.0; we merged a follow-up that updates it to v2.0.1;

@corhere
Copy link
Contributor

corhere commented Feb 6, 2024

I think we should hold off until #47248 is resolved as I suspect it is also a rootlesskit/v2 regression

@thaJeztah thaJeztah added this to the 23.0.10 milestone Mar 6, 2024
@thaJeztah thaJeztah mentioned this pull request Mar 6, 2024
Merged
@AkihiroSuda
Copy link
Member

AkihiroSuda commented Mar 14, 2024 •
edited

I think we should hold off until #47248 is resolved as I suspect it is also a rootlesskit/v2 regression

Being fixed in:

This was not a regression in rootlesskit v2, but rather related to changing the state dir from /tmp/... to /run/....

@corhere corhere modified the milestones: 23.0.10, 23.0.11 Mar 21, 2024
@corhere corhere modified the milestones: 23.0.11, 23.0.12 May 6, 2024
@corhere corhere modified the milestones: 23.0.12, 23.0.13 May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corhere corhere corhere approved these changes

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

@thaJeztah thaJeztah Awaiting requested review from thaJeztah

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
area/rootless Rootless mode
Projects
None yet
Milestone
23.0.13
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aepifanov @thaJeztah @corhere @AkihiroSuda