integration-cli: Update plugin test install image error #46902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check for the error returned by the plugin pull logic based off the containerd pull code. This code is used regardless of graphdriver or snapshotter. Signed-off-by: Derek McGowan <derek@mcg.dev>
rumpl
added
the
containerd-integration
|
I don't see any failures but I also don't know which job would be running |
Heh.... I may know why (😢); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check for the error returned by the plugin pull logic based off the containerd pull code. This code is used regardless of graphdriver or snapshotter.
Locally this test is failing for me on overlay2 and overlayfs snapshotter. The message which was previously being checked is in the old pull code which the plugin logic moved away from a few years ago. Let's see is CI handles it differently.