-
Notifications
You must be signed in to change notification settings - Fork 18.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vendor.mod: bump go line to 1.20 #46562
Conversation
neersighted
commented
Sep 28, 2023
•
edited
edited
- Follow-up to/related to update to go1.21.1, default to GOTOOLCHAIN=local #46069
- Related to Update to BuildKit 0.12 #45966 (comment)
Looks like you included the other commits as well; can you make it with only the |
(given that we're already on go1.20, that should still work I think?) |
Signed-off-by: Bjorn Neergaard <bjorn.neergaard@docker.com>
26af5d1
to
16063c7
Compare
Ah, I intentionally stacked this on top of your branch, but you make a fair point that we can do this independent of your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
wondering if we still need the -compat
option, or if we can remove that one (but that's perfectly fine for a separate PR);
Line 13 in a1d966c
"${SCRIPTDIR}"/with-go-mod.sh go mod tidy -modfile vendor.mod -compat 1.18 |
Yes, and I think we should merge this PR before mine to have the changes in the desired order 😄 |