Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor.mod: bump go line to 1.20 #46562

Merged
merged 1 commit into from
Sep 28, 2023
Merged

Conversation

neersighted
Copy link
Member

@neersighted neersighted commented Sep 28, 2023

@thaJeztah
Copy link
Member

Looks like you included the other commits as well; can you make it with only the go.mod changes?

@thaJeztah
Copy link
Member

(given that we're already on go1.20, that should still work I think?)

Signed-off-by: Bjorn Neergaard <bjorn.neergaard@docker.com>
@neersighted
Copy link
Member Author

Ah, I intentionally stacked this on top of your branch, but you make a fair point that we can do this independent of your changes.

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

wondering if we still need the -compat option, or if we can remove that one (but that's perfectly fine for a separate PR);

"${SCRIPTDIR}"/with-go-mod.sh go mod tidy -modfile vendor.mod -compat 1.18

@thaJeztah
Copy link
Member

Ah, I intentionally stacked this on top of your branch, but you make a fair point that we can do this independent of your changes.

Yes, and I think we should merge this PR before mine to have the changes in the desired order 😄

@thaJeztah thaJeztah merged commit 1239c96 into moby:master Sep 28, 2023
103 checks passed
@neersighted neersighted deleted the go_mod_bump branch September 29, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants