api/types/filters: fix errors not being matched by errors.Is()

[thaJeztah]

• relates to / these were added in 0d68591 / filters: Reduce duplication of bool filter parsing and invalidFilter error #44003

I found that the errors returned weren't matched with errors.Is() when wrapped.

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

[thaJeztah]

@vvoland @cpuguy83 ptal 🤗

[cpuguy83]

Oh I hate this semantic. Too easy to mess it up.
For buildkit I have a pending change that just implements Is and checks both for *<type> and **<type>

[thaJeztah]

Too easy to mess it up.

I KNOW! I spend quite some time scratching my head "WHY DOESN'T THIS WORK?"

... and all that was caused because I wanted to update containerd vendoring to 1.6.22, which also updated gotest.tools .. and then I hit;

• Discussion: cmp.ErrorIs is not a full replacement for cmp.ErrorType, but is now deprecated gotestyourself/gotest.tools#272

So... massive amounts of yak-shaving for me today 😂

[thaJeztah]

This was the other fun one; adding/removing the Value []string slice made it work or break;

https://go.dev/play/p/_3axGxDC8S8

package main

import (
	"errors"
	"fmt"
	"testing"
)

type customError struct {
	Name string
}

func (e customError) Error() string {
	return fmt.Sprintf("invalid name: %s", e.Name)
}

func (e customError) InvalidParameter() {}

type customError2 struct {
	Name  string
	Value []string
}

func (e customError2) Error() string {
	return fmt.Sprintf("invalid name: %s (%s)", e.Name, e.Value)
}

func (e customError2) InvalidParameter() {}

type customError3 struct {
	Name  string
	Value []string
}

func (e *customError3) Error() string {
	return fmt.Sprintf("invalid name: %s (%s)", e.Name, e.Value)
}

func (e *customError3) InvalidParameter() {}

func TestCustomErrorIs(t *testing.T) {
	err1 := customError{Name: "hello"}
	wrappedErr1 := fmt.Errorf("something went wrong: %w", err1)
	if !errors.Is(wrappedErr1, err1) {
		t.Errorf("customError: %v != %v", wrappedErr1, err1)
	}

	err2 := customError2{Name: "hello"}
	wrappedErr2 := fmt.Errorf("something went wrong: %w", err2)
	if !errors.Is(wrappedErr2, err2) {
		t.Errorf("customError2: %v != %v", wrappedErr2, err2)
	}

	err3 := &customError2{Name: "hello"}
	wrappedErr3 := fmt.Errorf("something went wrong: %w", err3)
	if !errors.Is(wrappedErr3, err3) {
		t.Errorf("*customError2: %v != %v", wrappedErr3, err3)
	}

	err4 := &customError3{Name: "hello"}
	wrappedErr4 := fmt.Errorf("something went wrong: %w", err4)
	if !errors.Is(wrappedErr4, err4) {
		t.Errorf("customError3: %v != %v", wrappedErr4, err4)
	}
}