-
Notifications
You must be signed in to change notification settings - Fork 18.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] testing buildkit 0.12 fixes #46035
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bjorn Neergaard <bjorn.neergaard@docker.com>
Signed-off-by: Bjorn Neergaard <bjorn.neergaard@docker.com>
This is a bit ugly, but it works given the new codegen output. Signed-off-by: Bjorn Neergaard <bjorn.neergaard@docker.com>
Introduced in containerd/containerd@dd3eedf Signed-off-by: Bjorn Neergaard <bjorn.neergaard@docker.com>
Signed-off-by: Bjorn Neergaard <bjorn.neergaard@docker.com>
ref was made a return value in moby/buildkit@330cf7a Signed-off-by: Bjorn Neergaard <bjorn.neergaard@docker.com>
We still use interface{} for now to reduce code churn. flightcontrol.Group was made generic in moby/buildkit@8ffc03b Signed-off-by: Bjorn Neergaard <bjorn.neergaard@docker.com>
This is a horrible kludge, but not /the worst/ as a reference to the underlying `osl.Sandbox` is part of the `Sandbox`; so keeping a reference to the underlying `osl.Interface` in the `Endpoint` is about the same level of impure. The lifecycle and assignment here is bad, but that can be fixed during future refactors, and keeps this diff minimal. Signed-off-by: Bjorn Neergaard <bjorn.neergaard@docker.com>
This method was added to the interface in moby/buildkit@963f161 Signed-off-by: Bjorn Neergaard <bjorn.neergaard@docker.com>
Introduced in moby/buildkit@6e87e4b Signed-off-by: Bjorn Neergaard <bjorn.neergaard@docker.com>
The controller moved to CacheManager in moby/buildkit@2b30693 Signed-off-by: Bjorn Neergaard <bjorn.neergaard@docker.com>
Duration is a deserializing wrapper introduced in moby/buildkit@e06c962 Signed-off-by: Bjorn Neergaard <bjorn.neergaard@docker.com>
…tore The concrete types are used instead of the interface after moby/buildkit@f044e0a Signed-off-by: Bjorn Neergaard <bjorn.neergaard@docker.com>
Introduced years ago in moby/buildkit@6644e1b Signed-off-by: Bjorn Neergaard <bjorn.neergaard@docker.com>
Introduced in moby/buildkit@4fc2d7b Signed-off-by: Bjorn Neergaard <bjorn.neergaard@docker.com>
vendor validation will fail on this one, as I manually modified the vendored files |
thaJeztah
force-pushed
the
buildkit_0.12_carry
branch
from
July 20, 2023 09:33
5b3988a
to
ef8e58d
Compare
Linter found some issues;
|
Two flaky test failures;
Some failures on Windows that I THINK are unrelated, but I'll kick those again after
Not sure what's happening with
|
Some buildkit CI failures;
|
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
buildkit_0.12_carry
branch
from
July 20, 2023 12:35
ef8e58d
to
460e100
Compare
Closing as the relevant changes are in BK/the original PR now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- A picture of a cute animal (not mandatory but encouraged)