Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[23.0 backport] api/server: allow empty body for POST /commit again #45569

Merged

Conversation

corhere
Copy link
Contributor

@corhere corhere commented May 18, 2023

The error returned by DecodeConfig was changed in
b6d58d7 and caused this to regress. Allow empty request bodies for this endpoint once again.

(cherry picked from commit 967c7bc)

- What I did

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

The error returned by DecodeConfig was changed in
b6d58d7 and caused this to regress.
Allow empty request bodies for this endpoint once again.

Signed-off-by: Cory Snider <csnider@mirantis.com>
(cherry picked from commit 967c7bc)
Signed-off-by: Cory Snider <csnider@mirantis.com>
@corhere corhere added this to the 23.0.7 milestone May 18, 2023
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neersighted neersighted merged commit 56ece96 into moby:23.0 May 19, 2023
90 checks passed
@corhere corhere deleted the backport-23.0/fix-empty-container-decode branch September 27, 2023 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants