[23.0 backport] libnet/d/ipvlan: gracefully migrate from older dbs #44937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corhere
added
area/networking
process/cherry-picked
kind/bugfix
neersighted
approved these changes
Feb 6, 2023
|
This will need a rebase in light of #44938; or we could go ahead and merge without |
|
#44938 was merged |
|
@thaJeztah @neersighted I'll rebase |
IPVLAN networks created on Moby v20.10 do not have the IpvlanFlag configuration value persisted in the libnetwork database as that config value did not exist before v23.0.0. Gracefully migrate configurations on unmarshal to prevent type-assertion panics at daemon start after upgrade. Fixes moby#44925 Signed-off-by: Cory Snider <csnider@mirantis.com> (cherry picked from commit 91725dd) Signed-off-by: Cory Snider <csnider@mirantis.com>
corhere
force-pushed
the
backport-23.0/fix-44925-ipvlan-panic
branch
from
0579575
to
427101f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
IPVLAN networks created on Moby v20.10 do not have the IpvlanFlag configuration value persisted in the libnetwork database as that config value did not exist before v23.0.0. Gracefully migrate configurations on unmarshal to prevent type-assertion panics at daemon start after upgrade.
- How I did it
- How to verify it
/var/lib/docker/network/files/local-kv.dbinto an upgraded installation- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)