[23.0 backport] graphdriver/overlay2: usingMetacopy ENOTSUP is non-fatal #44922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bjorn Neergaard <bneergaard@mirantis.com> (cherry picked from commit 3bcb350) Signed-off-by: Bjorn Neergaard <bneergaard@mirantis.com>
neersighted
added
area/storage/overlay
status/2-code-review
kind/bugfix
thaJeztah
changed the title
cpuguy83
approved these changes
Feb 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Change
usesMetacopyinoverlay2'scheck.goto return false/no error on aENOTSUPin lgetxattr(2).- How to verify it
By reading kernel documentation, more or less. ENOTSUP does not indicate that something went wrong, but that either the xattr in question, or xattr as a whole, are not supported by the filesystem.
- Description for the changelog
overlay2storage driver failing in a check for metacopy status instead of backing FS compatibility on incompatible backing filesystems.- A picture of a cute animal (not mandatory but encouraged)
