Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20.10 backport] distribution: checkSupportedMediaType: allow additional media-types #44569

Merged

Commits on Dec 2, 2022

  1. distribution: checkSupportedMediaType: allow additional media-types

    This addresses a regression introduced in 407e3a4,
    which turned out to be "too strict", as there's old images that use, for example;
    
        docker pull python:3.5.1-alpine
        3.5.1-alpine: Pulling from library/python
        unsupported media type application/octet-stream
    
    Before 407e3a4, such mediatypes were accepted;
    
        docker pull python:3.5.1-alpine
        3.5.1-alpine: Pulling from library/python
        e110a4a17941: Pull complete
        30dac23631f0: Pull complete
        202fc3980a36: Pull complete
        Digest: sha256:f88925c97b9709dd6da0cb2f811726da9d724464e9be17a964c70f067d2aa64a
        Status: Downloaded newer image for python:3.5.1-alpine
        docker.io/library/python:3.5.1-alpine
    
    This patch copies the additional media-types, using the list of types that
    were added in a215e15, which fixed a
    similar issue.
    
    Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
    (cherry picked from commit a6a5394)
    Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
    thaJeztah committed Dec 2, 2022
    Copy the full SHA
    966327c View commit details
    Browse the repository at this point in the history