Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.10] builder: fix running git commands on Windows #44332

Merged
merged 2 commits into from Oct 20, 2022
Merged

[20.10] builder: fix running git commands on Windows #44332

merged 2 commits into from Oct 20, 2022

Commits on Oct 20, 2022

  1. builder: fix running git commands on Windows 

    Setting cmd.Env overrides the default of passing through the parent
process' environment, which works out fine most of the time, except when
it doesn't. For whatever reason, leaving out all the environment causes
git-for-windows sh.exe subprocesses to enter an infinite loop of
access violations during Cygwin initialization in certain environments
(specifically, our very own dev container image).

Signed-off-by: Cory Snider <csnider@mirantis.com>
    @corhere
    corhere committed Oct 20, 2022
    Copy the full SHA
    05e25f7 View commit details
    Browse the repository at this point in the history

  2. builder: add missing doc comment 

    Signed-off-by: Cory Snider <csnider@mirantis.com>
    @corhere
    corhere committed Oct 20, 2022
    Copy the full SHA
    5b5b5c6 View commit details
    Browse the repository at this point in the history