[22.06 backport] Validate digest in repo for pull by digest #44328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
force-pushed
the
22.06_backport_ghsa-ambiguous-pull-by-digest
branch
2 times, most recently
from
0f6561b
to
5c60d13
Compare
This is accomplished by storing the distribution source in the content labels. If the distribution source is not found then we check to the registry to see if the digest exists in the repo, if it does exist then the puller will use it. Signed-off-by: Brian Goff <cpuguy83@gmail.com> Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 27530ef) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
- On Windows, we don't build and run a local test registry (we're not running docker-in-docker), so we need to skip this test. - On rootless, networking doesn't support this (currently) Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 4f43cb6) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
22.06_backport_ghsa-ambiguous-pull-by-digest
branch
from
5c60d13
to
c0be73f
Compare
|
LOL.. of course |
|
CI is happy; I'm bringing these in 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstreaming the patch for GHSA-vjgr-4595-fc6r to master.
This is a rebase and squash of https://github.com/moby/moby-ghsa-vjgr-4595-fc6r/pull/3
This is accomplished by storing the distribution source in the content labels. If the distribution source is not found then we check to the registry to see if the digest exists in the repo, if it does exist then the puller will use it.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)