Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integration: download busybox-w32 from GitHub Release #44299

Merged
merged 1 commit into from Oct 24, 2022

Conversation

crazy-max
Copy link
Member

@crazy-max crazy-max commented Oct 14, 2022

fixes #44298

- What I did

Download busybox-w32 through a docker image GitHub Release to avoid making too much requests to https://frippery.org/files/busybox.

- How I did it

Published GitHub Release with busybox-w32 binaries: https://github.com/moby/busybox/releases/tag/FRP-3329-gcf0fa4d13

Didn't updated to latest FRP-4716-g31467ddfc as it seems there are some issues with it: #44000

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: CrazyMax crazy-max@users.noreply.github.com

@crazy-max
Copy link
Member Author

Argh guess we need a proper Windows base image after all: https://github.com/moby/moby/actions/runs/3249933557/jobs/5333050380#step:11:33

Step 4/14 : FROM crazymax/busybox-w32:${BUSYBOX_VERSION} AS busybox
FRP-3329-gcf0fa4d13: Pulling from crazymax/busybox-w32
9e578c36694c: Pulling fs layer
9e578c36694c: Download complete
failed to register layer: re-exec error: exit status 1: output: hcsshim::ProcessBaseLayer \\?\C:\Users\runneradmin\AppData\Local\Temp\moby-root\windowsfilter\89dfa268f77584818e42f740f9e113dc477c6735c2e31aebac56b1e159ead111: The system cannot find the path specified.

So instead we might just build and push https://github.com/moby/moby/blob/master/contrib/busybox/Dockerfile in our pipeline. Maybe ghcr would be enough for this?

@tianon
Copy link
Member

tianon commented Oct 14, 2022

I don't have a problem with this approach (to be clear), but a few alternative ideas:

  • since the compressed downloads are relatively small, we could commit them directly to a new Git repo
  • we could make a new Git repo that includes a mirror of the downloads as GitHub Releases artifacts
  • we could make an S3 bucket that we mirror downloads into

(For any of these, I imagine we'd only go through the effort for versions we actually use, but if we were to automate it to make sure the "muscle is exercised" so to speak, that'd be fine too for all but my first option 😅)

@neersighted
Copy link
Member

Another alternate approach could be using GHCR + ORAS (I think OCI Artifacts isn't fully baked yet?), but that would require more tooling than the other alternatives.

@crazy-max crazy-max changed the title integration: download busybox-w32 from a Docker image integration: download busybox-w32 from GitHub Release Oct 24, 2022
@crazy-max
Copy link
Member Author

crazy-max commented Oct 24, 2022

As suggested created a GitHub repository https://github.com/crazy-max/busybox-w32 (should be moved to moby org) and pushed binaries to GitHub Release: https://github.com/crazy-max/busybox-w32/releases/tag/FRP-3329-gcf0fa4d13. cc @sam-thibault

Edit: https://github.com/moby/busybox/releases/tag/FRP-3329-gcf0fa4d13

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@thaJeztah thaJeztah added this to the v-next milestone Oct 24, 2022
@thaJeztah
Copy link
Member

Opened backports for 20.10 and 22.06;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workflows for testing on Microsoft Windows
5 participants