New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
integration: download busybox-w32 from GitHub Release #44299
Conversation
Argh guess we need a proper Windows base image after all: https://github.com/moby/moby/actions/runs/3249933557/jobs/5333050380#step:11:33
So instead we might just build and push https://github.com/moby/moby/blob/master/contrib/busybox/Dockerfile in our pipeline. Maybe ghcr would be enough for this? |
I don't have a problem with this approach (to be clear), but a few alternative ideas:
(For any of these, I imagine we'd only go through the effort for versions we actually use, but if we were to automate it to make sure the "muscle is exercised" so to speak, that'd be fine too for all but my first option 😅) |
Another alternate approach could be using GHCR + ORAS (I think OCI Artifacts isn't fully baked yet?), but that would require more tooling than the other alternatives. |
54f1519
to
1b399b8
Compare
As suggested created a GitHub repository https://github.com/crazy-max/busybox-w32 (should be moved to moby org) and pushed binaries to GitHub Release: https://github.com/crazy-max/busybox-w32/releases/tag/FRP-3329-gcf0fa4d13. cc @sam-thibault Edit: https://github.com/moby/busybox/releases/tag/FRP-3329-gcf0fa4d13 |
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
1b399b8
to
4f1d142
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Opened backports for 20.10 and 22.06; |
fixes #44298
- What I did
Download busybox-w32 through
a docker imageGitHub Release to avoid making too much requests to https://frippery.org/files/busybox.- How I did it
Published GitHub Release with busybox-w32 binaries: https://github.com/moby/busybox/releases/tag/FRP-3329-gcf0fa4d13
Didn't updated to latest
FRP-4716-g31467ddfc
as it seems there are some issues with it: #44000- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)
Signed-off-by: CrazyMax crazy-max@users.noreply.github.com