Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20.10] Update uses of Image platform fields in OCI image-spec #44127

Merged

Commits on Sep 10, 2022

  1. [20.10] Update uses of Image platform fields in OCI image-spec

    The OCI image spec is considering to change the Image struct and embedding the
    Platform type (see opencontainers/image-spec#959) in the go implementation.
    Moby currently uses some struct-literals to propagate the platform fields,
    which will break once those changes in the OCI spec are merged.
    
    Ideally (once that change arrives) we would update the code to set the Platform
    information as a whole, instead of assigning related fields individually, but
    in some cases in the code, image platform information is only partially set
    (for example, OSVersion and OSFeatures are not preserved in all cases). This
    may be on purpose, so needs to be reviewed.
    
    This patch keeps the current behavior (assigning only specific fields), but
    removes the use of struct-literals to make the code compatible with the
    upcoming changes in the image-spec module.
    
    (similar to commit 3cb933d)
    
    Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
    thaJeztah committed Sep 10, 2022
    Copy the full SHA
    6d6a236 View commit details
    Browse the repository at this point in the history