Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix constant WARNING: No swap limit support on cgroup v2 hosts #43649

Merged
merged 2 commits into from May 27, 2022

Conversation

AkihiroSuda
Copy link
Member

@AkihiroSuda AkihiroSuda commented May 27, 2022

- What I did
Fix constant WARNING: No swap limit support on cgroup v2 hosts

Fix #43646

- How I did it

Replace cgroups.ParseCgroupFile with cgroups.ParseCgroupFileUnified:

- How to verify it
Run docker info on cgroup v2 hosts with support for memory.swap.max, and make sure WARNING: No swap limit support is not printed

- Description for the changelog

Fix constant WARNING: No swap limit support on cgroup v2 hosts

- A picture of a cute animal (not mandatory but encouraged)
馃惂

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Fix issue 43646

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@AkihiroSuda AkihiroSuda added this to the 22.06.0 milestone May 27, 2022
@thaJeztah
Copy link
Member

Failure in CI in TestExecWithPrivileged - wondering if it's related to #43647, as docker logs is involved;

=== RUN   TestDockerSuite/TestExecWithPrivileged
    docker_cli_exec_test.go:463: assertion failed: 
        Command:  /usr/local/cli/docker logs parent
        ExitCode: 1
        Error:    exit status 1
        Stdout:   Privileged exec has not run yet
        Privileged exec has not run yet
        Privileged exec has not run yet
        Privileged exec has not run yet
        Privileged exec has not run yet
        Privileged exec has not run yet
        Privileged exec has not run yet
        Privileged exec has not run yet
        Privileged exec has not run yet
        Privileged exec has not run yet
        Running exec --privileged
        Running exec --privileged
        Running exec --privileged
        
        Stderr:   mknod: /tmp/sda: Operation not permitted
        mknod: /tmp/sda: Operation not permitted
        error from daemon in stream: Error grabbing logs: invalid character ',' looking for beginning of object key string
        
        
        
        Failures:
        ExitCode was 1 expected 0
        Expected no error
    --- FAIL: TestDockerSuite/TestExecWithPrivileged (1.17s)

I gave CI a kick

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link
Member

All green now 馃憤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[regression in master] docker info always shows WARNING: No swap limit support on cgroup v2 hosts
3 participants