Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.10] vendor: github.com/moby/buildkit v0.8.3-4-gbc07b2b8 #43023

Merged
merged 1 commit into from Nov 17, 2021
Merged

[20.10] vendor: github.com/moby/buildkit v0.8.3-4-gbc07b2b8 #43023

merged 1 commit into from Nov 17, 2021

Conversation

thaJeztah
Copy link
Member

imageutil: make mediatype detection more stricter to mitigate CVE-2021-41190.

full diff: moby/buildkit@244e8cd...bc07b2b

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@thaJeztah
[20.10] vendor: github.com/moby/buildkit v0.8.3-4-gbc07b2b8
da9c983 
imageutil: make mediatype detection more stricter to mitigate CVE-2021-41190.

full diff: moby/buildkit@244e8cd...bc07b2b

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah added this to the 20.10.11 milestone Nov 17, 2021
samuelkarp
samuelkarp approved these changes Nov 17, 2021
View reviewed changes
Copy link
Member

@samuelkarp samuelkarp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link
Member Author

hmm... why is this failing?

[2021-11-17T20:16:28.110Z] github.com/docker/distribution: Err: exit status 128, out: fatal: repository 'github.com/samuelkarp/docker-distribution' does not exist
[2021-11-17T20:16:28.110Z] 
[2021-11-17T20:16:28.110Z] github.com/containerd/containerd: Err: exit status 128, out: fatal: repository 'github.com/moby/containerd' does not exist

oh! I think we may need a scheme in the alias 🤔

@thaJeztah
Copy link
Member Author

opened #43028 to fix it

@thaJeztah thaJeztah merged commit 7568123 into moby:20.10 Nov 17, 2021
@thaJeztah thaJeztah deleted the 20.10_bump_buildkit branch November 17, 2021 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tianon tianon tianon approved these changes

@tonistiigi tonistiigi tonistiigi approved these changes

@samuelkarp samuelkarp samuelkarp approved these changes

Assignees
No one assigned
Labels
status/2-code-review
Projects
None yet
Milestone
20.10.11
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@thaJeztah @tianon @tonistiigi @samuelkarp