New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[20.10 backport] Bump go 1.16.6 #42643
Conversation
Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit ae5ddd2) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit f400e84) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
result of: `hack/vendor.sh archive/tar` Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 3ed804a) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This addresses CVE-2021-34558: https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2021-34558 go1.16.6 (released 2021-07-12) includes a security fix to the crypto/tls package, as well as bug fixes to the compiler, and the net and net/http packages. See the Go 1.16.6 milestone on the issue tracker for details: https://github.com/golang/go/issues?q=milestone%3AGo1.16.6+label%3ACherryPickApproved Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit fe6f1a4) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
75d5287
to
b0da207
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@thaJeztah : I just got beaten by upgrading to |
@thomasgl-orange ah, good call, yes. Are you interested in contributing a PR in the documentation repository? https://github.com/docker/docker.github.io/blob/master/engine/release-notes/index.md (I'll amend the release notes in this repository as well after that) |
TBH, I'm still on the fence if golang/go#40909 was the right thing to do; I don't see a reason for doing that (other than some obscure use-case reported by the user), as using a |
Thanks for the quick reply.
Would something like docker/docs#13284 be okay?
I don't mind having to set a distinct proxy env var for https (curl does it too, it won't use |
Thank you! I'll review that one shortly
Agreed. It's somewhat "unexpected". |
opening as draft, as this is based on #42642. I'll rebase once that's mergeddonebackport of: