New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows CI: Enable more integration tests #38469
Conversation
Codecov Report
@@ Coverage Diff @@
## master #38469 +/- ##
=========================================
Coverage ? 36.62%
=========================================
Files ? 608
Lines ? 45040
Branches ? 0
=========================================
Hits ? 16495
Misses ? 26265
Partials ? 2280 |
e212e6b
to
b145192
Compare
Re-opened and rebased to be able to see if these works better with current versions CI and Windows. |
98031c3
to
d535ba4
Compare
@thaJeztah FYI. There looks to be actually quite nasty bug on Windows CI as some tests actually fails on win-RS5 but it is still shown as green 😟 |
😞 Sounds like this issue I opened a while back; #39576 |
d535ba4
to
7633244
Compare
37e4039
to
d0923cc
Compare
d640ce5
to
ccdc043
Compare
385661c
to
dcd2a8a
Compare
61715ab
to
9f20357
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
thank you!
@AkihiroSuda @cpuguy83 ptal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Olli Janatuinen <olli.janatuinen@gmail.com>
9f20357
to
66a37b4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
- What I did
After seeing too many times that any Docker and Windows updates cannot be installed without testing all features which we need I decided fix the root cause, the fact that most of the integration tests are disabled on Windows CI.
So on this PR I enabled those tests what can be enabled with minimal changes to code.
- How I did it
I started enabling those tests and figured out the fact that work was actually started already on #37715 but (source: #37715 (comment))
so on #39240 added needed logic to Windows CI that those tests actually run.
Then year 2019 passed and on February I reopened this one and did find out that Windows CI was shown as passed even some tests actually failed so on #40599 I finally fixed that issue.
After getting Windows CI working correctly I noticed that there is acutally much less tests which can be enabled than I was originally thinking because many tests will need more modifications to working on Windows and because of the fact that there is open bugs on Windows #39191 #40998 #41354
- How to verify it
Look the CI log:
- A picture of a cute animal (not mandatory but encouraged)