Commits on Jul 12, 2018

1. lcow: fix debug in startServiceVMIfNotRunning() …

   When go-1.11beta1 is used for building, the following error is
   reported:
   
   > 14:56:20 daemon\graphdriver\lcow\lcow.go:236: Debugf format %s reads
   > arg #2, but call has 1 arg
   
   While fixing this, let's also fix a few other things in this
   very function (startServiceVMIfNotRunning):
   
   1. Do not use fmt.Printf when not required.
   2. Use `title` whenever possible.
   3. Don't add `id` to messages as `title` already has it.
   4. Remove duplicated colons.
   5. Try to unify style of messages.
   6. s/startservicevmifnotrunning/startServiceVMIfNotRunning/
   ...
   
   In general, logging/debugging here is a mess and requires much more
   love than I can give it at the moment. Areas for improvement:
   
   1. Add a global var logger = logrus.WithField("storage-driver", "lcow")
   and use it everywhere else in the code.
   2. Use logger.WithField("id", id) whenever possible (same for "context"
   and other similar fields).
   3. Revise all the errors returned to be uniform.
   4. Make use of errors.Wrap[f] whenever possible.
   
   Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>

   

   kolyshkin committed Jul 12, 2018
   Configuration menu

   • View commit details
   • Copy full SHA for b7a95a3
   • Browse repository at this point

   Copy the full SHA

   b7a95a3 View commit details

   Browse the repository at this point in the history