-
Notifications
You must be signed in to change notification settings - Fork 18.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update containerd to 1.1 #36895
Update containerd to 1.1 #36895
Conversation
SwarmKit bump is here: #36905 (just the wrapper update) |
18ef46f
to
aa619fd
Compare
aa619fd
to
ccaf32c
Compare
@dmcgowan @thaJeztah still blocked (swarmkit PR is merged upstream) |
ccaf32c
to
24ffa45
Compare
Codecov Report
@@ Coverage Diff @@
## master #36895 +/- ##
==========================================
- Coverage 34.62% 34.3% -0.32%
==========================================
Files 605 605
Lines 44765 44766 +1
==========================================
- Hits 15499 15359 -140
- Misses 27166 27342 +176
+ Partials 2100 2065 -35 |
24ffa45
to
8e62d6c
Compare
Updated GRPC to 1.12, which forced me to update everything else and vendor SwarmKit to moby/swarmkit#2649 |
8e62d6c
to
c876ffd
Compare
1b570f4
to
a3e0df7
Compare
Finally green tests, I am going to remove the blocked marker and update swarmkit to the merged version |
a3e0df7
to
f476ebd
Compare
Looks like you need to vendor with an older version of vndr (can do it inside the build container);
|
f476ebd
to
ccb3c3f
Compare
Updates swarmkit, grpc, and all related vendors Signed-off-by: Derek McGowan <derek@mcgstyle.net>
Signed-off-by: Derek McGowan <derek@mcgstyle.net>
ccb3c3f
to
a000934
Compare
Green now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Looks like the bump of gRPC caused a regression, because grpc now adds a limit that was not previously set; As of grpc/grpc-go@50d4175 / grpc/grpc-go@6f8b553 (grpc/grpc-go#1165) a limit of 4MB is applied, which can cause issues with many tasks running. |
Updates containerd to 1.1. This is pulls in needed updates and client features to complete containerd image store and buildkit integration.
Currently blocked by Swarmkit:
moby/swarmkit#2610moby/swarmkit#2452moby/swarmkit#2631#37059moby/swarmkit#2649