-
Notifications
You must be signed in to change notification settings - Fork 18.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.12.x] docs cherry picks #29332
[1.12.x] docs cherry picks #29332
Conversation
As is specified in 26964, it is possible to specify a filter based on the node name or node ID. This fix updates the related docs for that. Signed-off-by: Yong Tang <yong.tang.github@outlook.com> (cherry picked from commit c326e0a) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
…recated by identitytoken field Signed-off-by: milindchawre <milindchawre@gmail.com> (cherry picked from commit 72dd684) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
also updates related stack docs and removes stack_tasks.md Signed-off-by: Alicia Lauerman <allydevour@me.com> (cherry picked from commit 970ab9a) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This was added in e41de3e, but can be a bit confusing due to the "outer" brackets being for JSON, and the "inner" brackets to indicate optional values. During review of that change, this alternative format was suggested. Updating the example to use the format that was discussed during review :) Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 441c941) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 8e02b29) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Ding Fei <dingfei@stars.org.cn> (cherry picked from commit 9ccb1f1) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Ding Fei <dingfei@stars.org.cn> (cherry picked from commit 08fe24c) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
The following sentences (introduced in v1.11 via moby#21160) were misleading for Swarm mode services (>= v1.12) For networks backed by multi-host network driver, such as Overlay, this command also shows the container endpoints in other hosts in the cluster. These endpoints are represented as "ep-{endpoint-id}" in the output. Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp> (cherry picked from commit 2c288e6) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: yuexiao-wang <wang.yuexiao@zte.com.cn> (cherry picked from commit 98fb164) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Misty Stanley-Jones <misty@docker.com> (cherry picked from commit b39e65e) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
See moby#26099 (comment) Signed-off-by: Gerwim Feiken <g.feiken@tfe.nl> (cherry picked from commit 587b186) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
cURL 7.50 changed the validation for URL's when using socket connections. cURL 7.4x did not expect a hostname, whereas cURL 7.5x and above _requires_ a hostname. See curl/curl#936 This updates the example to take both versions into account, because cURL 7.4x is still widely used by distros. Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 2e0d6e6) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Leo Gallucci <leo.gallucci@zalando.de> (cherry picked from commit a5b69fa) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sean McIntyre <s.mcintyre@xverba.ca> (cherry picked from commit 2c38d43) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: dattatrayakumbhar04 <dattatraya.kumbhar@gslab.com> (cherry picked from commit 16c9cda) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Misty Stanley-Jones <misty@docker.com> (cherry picked from commit db3f06f) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: John Howard <jhoward@microsoft.com> (cherry picked from commit b9e65f4) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: lixiaobing10051267 <li.xiaobing1@zte.com.cn> (cherry picked from commit fc7c235) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Misty Stanley-Jones <misty@docker.com> (cherry picked from commit 2333657) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Misty Stanley-Jones <misty@docker.com> (cherry picked from commit 2178c84) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Yanqiang Miao <miao.yanqiang@zte.com.cn> update Signed-off-by: Yanqiang Miao <miao.yanqiang@zte.com.cn> (cherry picked from commit 71f1205) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Chris Gavin <chris@chrisgavin.me> (cherry picked from commit 35c82f4) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Qinglan Peng <qinglanpeng@zju.edu.cn> fix-contents-links Signed-off-by: Qinglan Peng <qinglanpeng@zju.edu.cn> (cherry picked from commit bac792c) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question, then LGTM
description: "How develop and use a plugin with the managed plugin system" | ||
keywords: "API, Usage, plugins, documentation, developer" | ||
advisory: "experimental" | ||
advisory: experimental |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this right? Going from not-experimental to experimental?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it's only removing the quotes (old version had "experimental")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right. LGTM!
1.12.x builds are currently running, so wait until the release is built/tagged |
|
cherry-picks of these PR's;
#26857 (d69fce7)
#27059 (c326e0a)
#27341 (72dd684)
#27363 (970ab9a)
#27428 (441c941)
#27429 (f988a9c)
#27431 (8e02b29)
#27434 (9ccb1f1 08fe24c)
#27526 (2c288e6)
#27546 (98fb164)
#27593 (b39e65e)
#27640 (587b186 2e0d6e6)
#27764 (a5b69fa)
#28451 (2c38d43)
#28602 (16c9cda)
#28607 (db3f06f)
#28778 (b9e65f4)
#28824 (fc7c235)
#28890 (2333657)
#28906 (2178c84)
#28928 (71f1205)
#29106 (35c82f4)
#29308 (bac792c)
ping @mstanleyjones - do not merge yet, as I think @andrewhsu is building binaries from this branch