docs: clarify docker attach #22611
Merged
docs: clarify docker attach #22611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM 👍 |
| @@ -39,6 +39,14 @@ using `CTRL-p CTRL-q` key sequence. | |||
| It is forbidden to redirect the standard input of a `docker attach` command | |||
| while attaching to a tty-enabled container (i.e.: launched with `-t`). | |||
|
|
|||
| While attach stream is connected to container's stdio, docker uses ~1MB memory | |||
| buffer to maximize the throughput of the application. If this buffer is reached | |||
| the speed of the API connection will start to have an effect the application | |||
|
one nit, but LGTM otherwise |
| @@ -39,6 +39,14 @@ using `CTRL-p CTRL-q` key sequence. | |||
| It is forbidden to redirect the standard input of a `docker attach` command | |||
| while attaching to a tty-enabled container (i.e.: launched with `-t`). | |||
|
|
|||
| While attach stream is connected to container's stdio, docker uses ~1MB memory | |||
There was a problem hiding this comment.
s/While attach stream/While an attach stream/?
s/docker uses ~1MB memory buffer/docker uses a ~1MB memory buffer/?
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
|
LGTM |
|
👍 But still missing from API docs: https://docs.docker.com/engine/reference/api/docker_remote_api_v1.23/#attach-to-a-container |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up for #22502
cc @aaronlehmann @cpuguy83
Signed-off-by: Tonis Tiigi tonistiigi@gmail.com